Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] handle differential calibration correction #113

Closed
wants to merge 66 commits into from

Conversation

aromanielloNTIA
Copy link
Member

draft PR so that github actions will run on this branch

Avoids some redundant additions and subtractions by working internally in dBW instead of dBm
- fully remove calibration from sigan interfaces. all calibration handling happens at the sensor object level
- alter the sigan interface: retry logic and calibration scaling now happens in the sensor acquire_samples method instead of sigan versions.
- dynamically set data reference point as part the measurement result based on which calibration scaling was applied
automatically recompute calibration data in the getter method
- Remove outdated and unnecessary instance variables
- Remove retry logic from acquire_samples to account for changes in the Sensor object
- Remove redundant properties that are the same as the base class
These properties no longer need to be overriden. Subclass constructors can just set the correct instance variables instead.
- simplify recompute_calibration methods
- cal_params is now an argument of acquire_time_domain_samples, and is intended to be used by passing action.parameters dicts which contain the required key/values to match calibration data to the measurement
- add some specific calibration-related exceptions
- update actions and unit tests
@dboulware
Copy link
Contributor

Closing until ready.

@dboulware dboulware closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants